Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add Figma provider #12529

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request introduces a new OAuth 2.0 provider for the Auth.js package: Figma. This integration allows users to authenticate with their Figma accounts.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 9:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 9:05am

Copy link

vercel bot commented Jan 22, 2025

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 105 lines in your changes missing coverage. Please review.

Project coverage is 39.58%. Comparing base (6a72f3d) to head (c9fd292).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/providers/figma.ts 0.00% 105 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12529      +/-   ##
==========================================
- Coverage   39.71%   39.58%   -0.14%     
==========================================
  Files         196      197       +1     
  Lines       31061    31166     +105     
  Branches     1374     1375       +1     
==========================================
  Hits        12337    12337              
- Misses      18724    18829     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falcowinkler
Copy link
Collaborator

thanks! for future pr's, have a look at the corrections for this PR. Keep in mind to use default implementations where possible (if the provider is spec compliant), and to update all links / references with the provider name. ☺️

@halvaradop
Copy link
Contributor Author

Thank you for reviewing this PR and my recent ones, and for improving them. I will follow your advice for future PRs. After these mistakes, I plan to review the codebase to better understand how the providers work, so I can avoid errors and unnecessary code when creating new providers.

@balazsorban44 balazsorban44 merged commit 14dfaf3 into nextauthjs:main Jan 28, 2025
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants